Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locust_taskset: take Task2 into account when checking for Task #62

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

thilp
Copy link
Member

@thilp thilp commented Sep 2, 2019

Fixes #61.

Description

Until Task2 completely replaces Task, both need to be treated the same way, as they represent the same data. In this particular function, they are treated the same way, save for a single statement, which caused the reported issue (#61).

Verified over examples/en.zalando.de.har (before/after).

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Bug fix (non-breaking change which fixes an issue)

TODO

List of tasks you will do to complete the PR:

  • Bump version

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

Fix #61.

Signed-off-by: Thibaut Le Page <thilp@thilp.net>
@zincr
Copy link

zincr bot commented Sep 2, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Signed-off-by: Thibaut Le Page <thilp@thilp.net>
@thilp thilp mentioned this pull request Sep 2, 2019
@thilp thilp marked this pull request as ready for review September 2, 2019 10:10
Signed-off-by: Thibaut Le Page <thilp@thilp.net>
@thilp thilp merged commit b65b0ad into master Sep 2, 2019
@thilp thilp deleted the issue-61 branch September 2, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Sequential Taskset
2 participants