Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme accent colour is preserved after switching between them #375

Closed
Stoppedpuma opened this issue Jun 21, 2024 · 5 comments
Closed

Theme accent colour is preserved after switching between them #375

Stoppedpuma opened this issue Jun 21, 2024 · 5 comments
Assignees

Comments

@Stoppedpuma
Copy link
Collaborator

Describe the bug
Switching to light and then back to dark theme keeps the blue accent colour.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to opposite theme
  2. Switch back
  3. Reproduced

Expected behavior
Accent colour to return back to the correct colour.

Screenshots / sample files

image

Desktop (please complete the following information):

  • OS: Arch Linux, Hyprland (Wayland compositor)

Additional context
Should probably follow the accent colour anyways? Or have a separate changeable accent colour for dark and light themes for the user to set.

@woelper
Copy link
Owner

woelper commented Jun 21, 2024

Accent color is designed to stay as it is. What would be the "correct" color in your case?

@Stoppedpuma
Copy link
Collaborator Author

I apparently need to quit writing bug reports at midnight because I completely lose the ability to speak english to the point of where even I can't understand myself.

Here's a video to show what this bug report is about instead:

1719010404.mp4

@woelper
Copy link
Owner

woelper commented Jun 22, 2024

Ahhh! Cool! I get it!

No worries, better to write a bug report at midnight than to forget about it! :)

@Stoppedpuma
Copy link
Collaborator Author

Suggestion if you don't mind, would you be open to changing "Accent colour" to "Dark mode accent colour" and "Light mode accent colour" allowing for two different accent colours based on the theme, one for the dark theme and the other for the light theme?

@woelper woelper self-assigned this Jun 22, 2024
@woelper
Copy link
Owner

woelper commented Jun 22, 2024

I went with fixing the issue first. I think two accent colors would be more complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants