Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Optimize make dependecy obtention #2207

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Optimize make dependecy obtention #2207

merged 1 commit into from
Jun 28, 2019

Conversation

2opremio
Copy link
Contributor

Using xargs was slow, we can use -deps to obtain the dependencies directly.

Also, remove redundant dependencies.

@2opremio
Optimize make dependecy obtention
e32c9d0 
Using xargs was slow, we can use -deps to obtain the dependencies directly.

Also, remove redundant dependencies.
@2opremio 2opremio requested a review from hiddeco June 28, 2019 10:56
hiddeco
hiddeco approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally to ensure there were no hidden MacOS <> Linux quirks. Thanks @2opremio 🥇

@2opremio 2opremio merged commit d7ea0f6 into fluxcd:master Jun 28, 2019
@squaremo squaremo added this to the 1.13.2 milestone Jul 10, 2019
squaremo pushed a commit that referenced this pull request Jul 10, 2019
@2opremio @squaremo
Merge pull request #2207 from 2opremio/get-dependencies-faster
779051f 
Optimize make dependecy obtention
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@2opremio @hiddeco @squaremo