Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Configurable log format #2138

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Configurable log format #2138

merged 2 commits into from
Jun 10, 2019

Conversation

bzon
Copy link
Contributor

@bzon bzon commented Jun 9, 2019

Propose changes

Make structured logging configurable in JSON format.

cmd/fluxd/main.go Outdated Show resolved Hide resolved
cmd/fluxd/main.go Outdated Show resolved Hide resolved
cmd/fluxd/main.go Outdated Show resolved Hide resolved
cmd/helm-operator/main.go Outdated Show resolved Hide resolved
cmd/helm-operator/main.go Outdated Show resolved Hide resolved
chart/flux/values.yaml Outdated Show resolved Hide resolved
chart/flux/templates/deployment.yaml Show resolved Hide resolved
chart/flux/README.md Outdated Show resolved Hide resolved
chart/flux/Chart.yaml Outdated Show resolved Hide resolved
@bzon
Copy link
Contributor Author

bzon commented Jun 10, 2019

@stefanprodan the requested changes have been applied accordingly.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bzon

cmd/fluxd/main.go Outdated Show resolved Hide resolved
cmd/helm-operator/main.go Outdated Show resolved Hide resolved
cmd/fluxd/main.go Outdated Show resolved Hide resolved
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@stefanprodan stefanprodan merged commit 00ab444 into fluxcd:master Jun 10, 2019
@bzon bzon deleted the configurable-log-format branch June 10, 2019 13:44
@hiddeco hiddeco added this to the v1.13.0 milestone Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants