Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Improve internal kubernetes error logging #2000

Merged
merged 1 commit into from
May 1, 2019
Merged

Improve internal kubernetes error logging #2000

merged 1 commit into from
May 1, 2019

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Apr 30, 2019 •
edited
Loading

  1. Remove duplicated timestamp keyval
  2. Print full path to kubernetes file emitting the error

Removes rough edges in #1957

@2opremio
Improve internal kubernetes error logging
4c0ce35 
1. Remove duplicated timestamp keyval
2. Print full path to kubernetes file emitting the error
@2opremio 2opremio requested a review from hiddeco April 30, 2019 18:56
squaremo
squaremo approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it'll work! Perhaps a bit brittle, but not more so than before :-)

@2opremio 2opremio merged commit f5df2fe into fluxcd:master May 1, 2019
@2opremio 2opremio deleted the improve-internal-k8s-logging branch May 1, 2019 14:45
@hiddeco hiddeco added this to the v1.12.2 milestone May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squaremo squaremo squaremo approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@2opremio @squaremo @hiddeco