This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fixup arm and arm64 builds; Refactor Makefile; #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay. I finally got tests passed :) jfyi: @2opremio |
2opremio
reviewed
Apr 18, 2019
2opremio
reviewed
Apr 18, 2019
|
Great work! it's shaping up nicely! Wanna bite the bullet and create multi-architecture images when pushing from CircleCI? It can be done in a separate PR if you want. The advantage of that is that people interested in ARM images won't have to build locally. |
|
Yup, I'd love to see official multi-architecture images too. I'd vote for a separate PR :) |
2opremio
reviewed
Apr 18, 2019
Awesome!! Looking forward to that work. Almost ready to merge, just a small nitpick. |
2opremio
approved these changes
Apr 20, 2019
|
This is thorough and neatly done -- thanks for giving it another go @brezerk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HW: Rock64 (arm64v8)
OS: Gentoo
Hi
Thank you for nice DevOps tool. I was looking forward to build if for my arm64 k8s cluster and got some issues.
Here you are the changes I had to make to compile the binaries and build the images.
Also, i have noticed comments/discussions around #1761 , #1411 and #1474 so i have tried to update Makefile accordingly.
Retry for #1942 :)