Skip to content

Commit

Permalink
Merge: python#27630: Be consistent in how _XXX/_encoded_XXX vars are …
Browse files Browse the repository at this point in the history
…initialized.
  • Loading branch information
bitdancer committed Sep 9, 2016
2 parents 71c01d4 + eaab1ca commit f03bcfd
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions Lib/email/generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def flatten(self, msg, unixfrom=False, linesep=None):
self._NL = policy.linesep
self._encoded_NL = self._encode(self._NL)
self._EMPTY = ''
self._encoded_EMPTY = self._encode('')
self._encoded_EMPTY = self._encode(self._EMPTY)
# Because we use clone (below) when we recursively process message
# subparts, and because clone uses the computed policy (not None),
# submessages will automatically get set to the computed policy when
Expand Down Expand Up @@ -137,10 +137,6 @@ def clone(self, fp):
# it has already transformed the input; but, since this whole thing is a
# hack anyway this seems good enough.

# Similarly, we have _XXX and _encoded_XXX attributes that are used on
# source and buffer data, respectively.
_encoded_EMPTY = ''

def _new_buffer(self):
# BytesGenerator overrides this to return BytesIO.
return StringIO()
Expand Down Expand Up @@ -402,10 +398,6 @@ class BytesGenerator(Generator):
The outfp object must accept bytes in its write method.
"""

# Bytes versions of this constant for use in manipulating data from
# the BytesIO buffer.
_encoded_EMPTY = b''

def write(self, s):
self._fp.write(s.encode('ascii', 'surrogateescape'))

Expand Down

0 comments on commit f03bcfd

Please sign in to comment.