Skip to content

Commit

Permalink
Issue python#16537: Check whether self.extensions is empty in setup.py.
Browse files Browse the repository at this point in the history
Patch by Jonathan Hosmer.
  • Loading branch information
berkerpeksag committed Sep 27, 2014
1 parent 1f3a88f commit 21c8d5c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions Misc/ACKS
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,7 @@ Randall Hopper
Nadav Horesh
Alon Horev
Jan Hosang
Jonathan Hosmer
Alan Hourihane
Ken Howard
Brad Howes
Expand Down
6 changes: 6 additions & 0 deletions Misc/NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ Library
- Issue #22448: Improve canceled timer handles cleanup to prevent
unbound memory usage. Patch by Joshua Moore-Oliva.

Build
-----

- Issue #16537: Check whether self.extensions is empty in setup.py. Patch by
Jonathan Hosmer.


What's New in Python 3.4.2?
===========================
Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,9 @@ def build_extensions(self):

build_ext.build_extensions(self)

longest = max([len(e.name) for e in self.extensions])
longest = 0
if self.extensions:
longest = max([len(e.name) for e in self.extensions])
if self.failed:
longest = max(longest, max([len(name) for name in self.failed]))

Expand Down

0 comments on commit 21c8d5c

Please sign in to comment.