✨ Router scroll behaviour, fix #1071 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvennemann
reviewed
Dec 6, 2018
| @@ -62,15 +62,25 @@ export function createApp (isServer) { | |||
| base: siteData.base, | |||
| mode: 'history', | |||
| fallback: false, | |||
| routes | |||
| routes, | |||
| scrollBehavior (to, from, savedPosition) { | |||
There was a problem hiding this comment.
What about cases when to.hash is set?
There was a problem hiding this comment.
That interferes with plugin-active-header-links unfortunately. It causes the website to jump around when the anchor is being pushed.
But jumping to an anchor still works with the native browser behaviour.
There was a problem hiding this comment.
Alright perfect, then i guess in the old implementation it was just to disable scroll behavior via some flag.
There was a problem hiding this comment.
Ah that would make sense here, too! Have to check that out later.
ulivz
requested changes
Dec 7, 2018
There was a problem hiding this comment.
This PR seems to be a revert of 5b0cdcf#diff-4371af1d933b93cddb889e7b132d150a.
Please address comments
15 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1071
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
→ see Add native-like scroll behaviour when changing routes #1071
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I removed
smooth-scrollas it was causing issues when used withactive-header-links.