Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also run CI on fix/* and perf/* branches #7435

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

brillout
Copy link
Contributor

Description

Just a small thing.

I find myself creating branches named feat/fix-* because I want the CI to be run.

Maybe we can also run the CI on fix/* branches, so that I create branches named fix/* instead of feat/fix-*.

Same for perf/*.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@brillout brillout changed the title fix: also run CI on fix/* and perf/* branches chore: also run CI on fix/* and perf/* branches Mar 24, 2022
@patak-dev
Copy link
Member

Vite's test suite is getting more robust with the latest changes in the 2.9 beta. But we still get some false fails. I don't think that we gain much by duplicating the tests for fix and perf at this point. Maybe we could revisit later.

@brillout
Copy link
Contributor Author

From Vite team's perspective, this may seem like a duplication of tests, but it isn't for the contributor: I let Vite's CI test my branch on my brillout fork of Vite, so that I know I didn't break anything before opening a PR.

Currently, if I create a branch fix/some-bug on my brillout Vite fork, the CI isn't run.

That's why I create branches named feat/fix-* so that the CI is run.

Anyways, it's just a small thing and I'm fine if we close this PR.

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Mar 25, 2022
@patak-dev patak-dev merged commit f10c7cc into vitejs:main Mar 27, 2022
@brillout brillout deleted the feat/fix-ci branch September 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants