Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain dep handling in dev and build #7187

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 6, 2022

Description

Closes #4680

Additional context

The docs in this spot right now could be off, since the first part of this page is small sense of "pride". The note blockquote however contrasts a small pitfall. Maybe it should be in a new section on the page?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the documentation Improvements or additions to documentation label Mar 6, 2022
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-dev patak-dev merged commit b81e1a2 into vitejs:main Mar 6, 2022
@bluwy bluwy deleted the docs-dep-handling branch March 6, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using obfuscated packages: Uncaught (in promise) TypeError: {......} is not a constructor
2 participants