Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanImports should ignore /coverage directory by default? #2599

Closed
J3n5en opened this issue Mar 19, 2021 · 3 comments · Fixed by #7469
Closed

scanImports should ignore /coverage directory by default? #2599

J3n5en opened this issue Mar 19, 2021 · 3 comments · Fixed by #7469
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@J3n5en
Copy link

J3n5en commented Mar 19, 2021

jest is a common JavaScript testing framework,its test coverage reports are output to /coverage by default

Now, some common folders are ignored, but coverage is not, it contains a lot of html files, which may cause out of memory in windows.

function globEntries(pattern: string | string[], config: ResolvedConfig) {
return glob(pattern, {
cwd: config.root,
ignore: [
'**/node_modules/**',
`**/${config.build.outDir}/**`,
`**/__tests__/**`
],

Should we ignore this folder by default?

@patak-dev
Copy link
Member

I think this is a good idea. The ignore patterns should also be configurable

@hungdoansy
Copy link

hungdoansy commented Mar 23, 2021

Got the same issue today. I managed to get over it by adding this

optimizeDeps: {
  exclude: ['**/cypress-coverage/**'], // this doesn't help
  entries: ['index.html'],
},

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 23, 2021
@J3n5en
Copy link
Author

J3n5en commented Mar 24, 2021

@hungdoansy
yes, optimizeDeps.entries will resolve this problem. But it might be better if the ignore patterns could be configured.😜

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants