Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): lit templates will create application instead of library #12459

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

fi3ework
Copy link
Member

Description

supersede #12440

Additional context

Should be released in create-vite@4.3.0


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@fi3ework fi3ework changed the title feat(create-vite): Lit templates will create application instead of library feat(create-vite): lit templates will create application instead of library Mar 17, 2023
@patak-dev patak-dev merged commit 8186b9b into vitejs:main Mar 21, 2023
@fi3ework fi3ework deleted the lit-create-app branch March 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants