feat: Configurable live seekable window #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkatsev It seems that tests fail for timeout. I tried locally on 2.3.0 and errors are the same. Any ideas? |
|
Not sure, I'll take a look. |
dario-fiore
changed the title
gkatsev
approved these changes
Dec 2, 2020
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During live streaming in low bandwidth situations
playback-watchertry different times to seek to live edge without waiting for buffered contents. This behaviour causing waiting status "loop" because buffer will never reach minimum contents in order to perform playback.Specific Changes proposed
Configure method
beforeSeekableWindow_in order to accept new configuration parameterliveRangeSafeTimeDeltato adjust safe time delta.Requirements Checklist