Remove Flash handling #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
force-pushed
the
remove-flash
branch
2 times, most recently
from
8df4a06
to
4675aca
Compare
forbesjo
force-pushed
the
remove-flash
branch
4 times, most recently
from
ef714de
to
659099a
Compare
mjneil
reviewed
Jan 25, 2018
README.md
Outdated
| [videojs-flash](https://github.com/videojs/videojs-flash) on your page before including | ||
| videojs-http-streaming | ||
| ### Flash Support | ||
| This plugin has no flash support. Instead, it is recommended that users use flash support is provided |
There was a problem hiding this comment.
it is recommended that users use flash support is provided through the
This is a confusing sentence
There was a problem hiding this comment.
I'll clean that up
mjneil
reviewed
Jan 25, 2018
| @@ -252,6 +252,7 @@ const calculateBufferedPercent = function(adjustedRange, | |||
| // overlap duration so that it actually starts at the beginning of referenceRange | |||
| // by including the difference between the two Range's durations | |||
| // This is a work around for the way Flash has no buffer before currentTime | |||
| // TODO: see if this is still necessary since Flash isn't included | |||
There was a problem hiding this comment.
This entire function can probably just go. There are a few functions in this file that I don't think have been used since simple fetcher logic was implemented
There was a problem hiding this comment.
We can do this sort of cleanup in another PR though
forbesjo
force-pushed
the
remove-flash
branch
from
f7344f7
to
add020c
Compare
forbesjo
force-pushed
the
remove-flash
branch
from
add020c
to
4b2d24d
Compare
mjneil
approved these changes
Jan 29, 2018
| @@ -139,7 +139,7 @@ QUnit.test('creates appropriate PlaylistLoader for sourceType', function(assert) | |||
| 'created a dash playlist loader'); | |||
| }); | |||
|
|
|||
| QUnit.test('resets SegmentLoader when seeking in flash for both in and out of buffer', | |||
| QUnit.test('resets SegmentLoader when seeking for both in and out of buffer', | |||
There was a problem hiding this comment.
resets SegmentLoader when seeking for both in and out of buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes Flash support from the project.
Specific Changes proposed
Don't have a separate Flash mode source handler, move contrib-mse into this project. Another PR will handle refactoring the contrib-mse code to remove unneeded Flash workarounds.
Requirements Checklist