Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-4297 Include local session description in dialdbg #70

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

benjirewis
Copy link
Member

@benjirewis benjirewis commented Aug 7, 2023

RSDK-4297

Include the offered local session description in dialdbg's output. It seems like issues with the created session description are common sources of difficult-to-find WebRTC bugs.

New WebRTC output from dialdbg looks like:

Debugging dial with WebRTC...

mDNS could not be used to connect
authentication successful in 111ms
offered local session description was
	v=0
	o=- 4176189070910177742 55142000 IN IP4 0.0.0.0
	s=-
	t=0 0
	a=fingerprint:sha-256 [redacted for security]
	a=group:BUNDLE 0
	m=application 9 UDP/DTLS/SCTP webrtc-datachannel
	c=IN IP4 0.0.0.0
	a=setup:actpass
	a=mid:0
	a=sendrecv
	a=sctp-port:5000
	a=ice-ufrag:[redacted for security]
	a=ice-pwd:[redacted for security]
	
WebRTC connection establishment successful in 3494ms
selected ICE candidate pair was:
	(local) udp srflx 74.62.33.18:504670.0.0.0 <-> (remote) udp srflx 71.167.222.76:507040.0.0.0
average RTT across established WebRTC connection: 106ms

nominated ICE candidates:

	remote ICE candidate:
		IP address: 71.167.222.76
		port: 50704
		nominated 400.666µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 10.1.5.217
		port: 55905
		nominated 403µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 127.0.0.1
		port: 45984
		nominated 403.541µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 71.167.222.76
		port: 55905
		nominated 399.666µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 10.1.5.217
		port: 33688
		nominated 400.958µs ago
		relay protocol: udp
		network type: udp4
	local ICE candidate:
		IP address: eb820f30-74e4-4d41-8da5-0b7d05ef4c4f.local
		port: 58843
		nominated 412.583µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 71.167.222.76
		port: 59238
		nominated 399.333µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 71.167.222.76
		port: 52665
		nominated 400µs ago
		relay protocol: udp
		network type: udp4
	local ICE candidate:
		IP address: eb820f30-74e4-4d41-8da5-0b7d05ef4c4f.local
		port: 61543
		nominated 409.25µs ago
		relay protocol: udp
		network type: udp6
	remote ICE candidate:
		IP address: 100.104.116.117
		port: 59238
		nominated 402.458µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: fd7a:115c:a1e0:ab12:4843:cd96:6268:7475
		port: 37556
		nominated 404µs ago
		relay protocol: udp
		network type: udp6
	local ICE candidate:
		IP address: 74.62.33.18
		port: 50467
		nominated 411.291µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 100.104.116.117
		port: 53446
		nominated 401.625µs ago
		relay protocol: udp
		network type: udp4
	local ICE candidate:
		IP address: 54.244.51.58
		port: 48319
		nominated 410.875µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: 127.0.0.1
		port: 50117
		nominated 401.333µs ago
		relay protocol: udp
		network type: udp4
	remote ICE candidate:
		IP address: fd7a:115c:a1e0:ab12:4843:cd96:6268:7475
		port: 55104
		nominated 404.458µs ago
		relay protocol: udp
		network type: udp6

no mDNS addresses discovered on current subnet

Done debugging dial with WebRTC.

@benjirewis benjirewis requested a review from stuqdog August 7, 2023 19:32
@benjirewis benjirewis requested a review from a team as a code owner August 7, 2023 19:32
@benjirewis benjirewis requested review from maximpertsov and removed request for a team August 7, 2023 19:32
@benjirewis benjirewis merged commit 0355d3e into viamrobotics:main Aug 7, 2023
3 checks passed
@benjirewis benjirewis deleted the sdp-info-dialdbg branch August 7, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants