-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2781: QA drive a rover flutter app #3398
DOCS-2781: QA drive a rover flutter app #3398
Conversation
sguequierre
commented
Sep 4, 2024
•
edited
Loading
edited
- tested on rover rental bot and does appear to work if a bit flaky, definitely produces a square-like movement and hypothetically the call is the exact same as all the others that do work.
- paired with @kevin49999 and updated code for latest SDK version. Involved readding .id but we kept my other change with isloading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we still don't know why things are the way that they are here, maybe @clintpurser or @Oabraham1 can provide SME review/help understand the flakiness
`fvm` is a useful tool for targeting specific flutter versions. | ||
You can run `fvm use 3.19.6` to target Flutter 3.19.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a naive user, I'm not sure when/where I'd run this command. Is it after a certain step in this guide? Is it every time I build or run the app?
Please clarify. Otherwise good to go since you've tested and it works now! Yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not every time but you can run it whenever before building the app. I'm honestly not sure if this needs to be clarified for most of our target audience (at this point more experienced developers) but I'll add a sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nit
Co-authored-by: JessamyT <75634662+JessamyT@users.noreply.github.com>
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3398 |