Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2781: QA drive a rover flutter app #3398

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

sguequierre
Copy link
Collaborator

@sguequierre sguequierre commented Sep 4, 2024

  • tested on rover rental bot and does appear to work if a bit flaky, definitely produces a square-like movement and hypothetically the call is the exact same as all the others that do work.
  • paired with @kevin49999 and updated code for latest SDK version. Involved readding .id but we kept my other change with isloading.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Sep 4, 2024
@sguequierre sguequierre changed the title Build app DOCS-2781: QA drive a rover flutter app Sep 4, 2024
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we still don't know why things are the way that they are here, maybe @clintpurser or @Oabraham1 can provide SME review/help understand the flakiness

Comment on lines 74 to 75
`fvm` is a useful tool for targeting specific flutter versions.
You can run `fvm use 3.19.6` to target Flutter 3.19.6.
Copy link
Collaborator

@JessamyT JessamyT Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a naive user, I'm not sure when/where I'd run this command. Is it after a certain step in this guide? Is it every time I build or run the app?
Please clarify. Otherwise good to go since you've tested and it works now! Yay!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not every time but you can run it whenever before building the app. I'm honestly not sure if this needs to be clarified for most of our target audience (at this point more experienced developers) but I'll add a sentence

Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

docs/tutorials/control/flutter-app.md Outdated Show resolved Hide resolved
Co-authored-by: JessamyT <75634662+JessamyT@users.noreply.github.com>
@viambot
Copy link
Member

viambot commented Sep 20, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3398

@sguequierre sguequierre merged commit 5da53a7 into viamrobotics:main Sep 20, 2024
9 checks passed
@sguequierre sguequierre deleted the DOCS-2781/qa-drive-a-rover branch September 20, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants