Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-2349: Add CaptureAllFromCamera API #3126

Merged
merged 1 commit into from
Jul 12, 2024
Merged

DOCS-2349: Add CaptureAllFromCamera API #3126

merged 1 commit into from
Jul 12, 2024

Conversation

andf-viam
Copy link
Contributor

@andf-viam andf-viam commented Jul 11, 2024 •
edited
Loading

Add CaptureAllFromCamera API.

  • Only for PySDK and Go, not implemented in Flutter.
  • Looks like PySDK has fixed / moved more data type links upstream.
  • I guessed at whatever Go param opts and return VisCapture type mean. Former total guess, latter from the PySDK return. Feel free to update upstream or create a follow-up ticket if you would like to tell Eng what to put here instead!
  • No code sample for Go. Please feel free to create a ticket to add one upstream if you'd like to see one!

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jul 11, 2024
@viambot
Copy link
Member

viambot commented Jul 11, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3126

npentrel
npentrel approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@npentrel npentrel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - we do need a follow up ticket here to fix the upstream Go docs - that is our responsibility. This is ok to merge and I will create the ticket but usually that is the ticket doer's responsibility

@npentrel npentrel merged commit 4b98abd into viamrobotics:main Jul 12, 2024
9 checks passed
@andf-viam andf-viam deleted the DOCS-2349-add-capture-all-api branch July 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npentrel npentrel npentrel approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andf-viam @viambot @npentrel