Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve bundled storage #179

Merged
merged 3 commits into from
May 4, 2022
Merged

fix: improve bundled storage #179

merged 3 commits into from
May 4, 2022

Conversation

atinux
Copy link
Member

@atinux atinux commented May 2, 2022

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Improve normalizeKey to remove duplicate :
  • Use assets:nitro:bundled: for the bundledStorage to avoid having to prefix with / (ex: cache:content instead of /cache/content)

@atinux atinux requested a review from pi0 May 3, 2022 12:36
@pi0 pi0 merged commit d4cb863 into main May 4, 2022
@pi0 pi0 deleted the fix/bundled-storage branch May 4, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atinux @pi0