Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is ioredis a dependency? #2462

Closed
boehs opened this issue May 23, 2024 · 1 comment
Closed

Why is ioredis a dependency? #2462

boehs opened this issue May 23, 2024 · 1 comment

Comments

@boehs
Copy link

boehs commented May 23, 2024

ioredis is a peer dependency of unstorage, but it is a dependency of nitro despite it not being used. The docs of unstorage say you should install ioredis if you want redis in unstorage, and I agree with them. Seems to have been introduced in #2266, but I'm honestly not sure why.

I personally think it would be better to not burden the 99% of people not using redis with this, especially as

  1. no other unstorage dependencies get preferential treatment like this
  2. people who need it can run one command and be happy forever
  3. a majority of people couldn't use this even if they wanted because a majority of nitro targets are likely serverless
@pi0
Copy link
Member

pi0 commented May 23, 2024

Hi. ioredis (sadly) had been always being installed through nitro > unstorage as a dependency for a long time. we removed it from unstorage to make the situation better but since there are already production users who were assuming it is installed (reported in #2265) as a mitigation effort we basically moved dep to nitro.

I'm not happy it is there (and lots of more transitional unused sub-dependencies and extra files) but until Nitro v3, we have to sadly keep it there.

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants