fix: fetch incompatible set & vocabulary if version is lower

subconcept-labs · Aug 25, 2020 · 1f3a80e · 1f3a80e
1 parent 6faf98a
commit 1f3a80e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/ulangi-local-database/src/models/IncompatibleSetModel.ts b/packages/ulangi-local-database/src/models/IncompatibleSetModel.ts
@@ -31,7 +31,7 @@ export class IncompatibleSetModel {
           const query = squel
             .select()
             .from(TableName.INCOMPATIBLE_SET)
-            .where('lastTriedCommonVersion != ?', currentCommonVersion)
+            .where('lastTriedCommonVersion < ?', currentCommonVersion)
             .limit(limit)
             .toParam();
 

diff --git a/packages/ulangi-local-database/src/models/IncompatibleVocabularyModel.test.ts b/packages/ulangi-local-database/src/models/IncompatibleVocabularyModel.test.ts
@@ -274,7 +274,7 @@ describe('IncompatibileVocabularyModel', (): void => {
             expect(vocabularyIds).toIncludeSameMembers([]);
           });
 
-          test('should return incompatible vocabulary ids if current version is lower', async (): Promise<
+          test('should not return incompatible vocabulary ids if current version is lower', async (): Promise<
             void
           > => {
             const {

diff --git a/packages/ulangi-local-database/src/models/IncompatibleVocabularyModel.ts b/packages/ulangi-local-database/src/models/IncompatibleVocabularyModel.ts
@@ -31,7 +31,7 @@ export class IncompatibleVocabularyModel {
           const query = squel
             .select()
             .from(TableName.INCOMPATIBLE_VOCABULARY)
-            .where('lastTriedCommonVersion != ?', currentCommonVersion)
+            .where('lastTriedCommonVersion < ?', currentCommonVersion)
             .limit(limit)
             .toParam();