Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.0 is broken in go1.16 #7

Closed
srimaln91 opened this issue Jan 25, 2022 · 2 comments · Fixed by #8
Closed

v1.1.0 is broken in go1.16 #7

srimaln91 opened this issue Jan 25, 2022 · 2 comments · Fixed by #8

Comments

@srimaln91
Copy link

Hi,

Thank you for this awesome project.

I'm getting the following error when importing the package in Go 1.16

../../go/pkg/mod/github.com/twpayne/go-polyline@v1.1.0/polyline.go:93:12: undefined: math.MaxUint
../../go/pkg/mod/github.com/twpayne/go-polyline@v1.1.0/polyline.go:94:10: undefined: math.MinInt

It seems there are some breaking changes in math package in recent Go versions.
https://go-review.googlesource.com/c/go/+/317911/

Please let me know if you want any contribution from my end.

Thank you again.
@twpayne twpayne mentioned this issue Jan 25, 2022
Merged
@twpayne
Copy link
Owner

twpayne commented Jan 25, 2022

Thanks for reporting this. #8 fixes it, and I've tagged v1.1.1 so you can go get the fixed version.

@srimaln91
Copy link
Author

Thank you @twpayne 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable support for Go 1.16 twpayne/go-polyline
2 participants
@twpayne @srimaln91