Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After importing variables from figma, remote update is not triggered while using genericVersionedStorage, and diff change seems has excepetion #3144

Open
kibbon opened this issue Sep 18, 2024 · 1 comment

Comments

@kibbon
Copy link

kibbon commented Sep 18, 2024

Token studio v2.0.3 / Figma 124.3.2

Describe the bug
Total 2 bugs:

  1. Import variables from figma, don't triggle updating to remote while using genericVersionedStorage -> expect triggled as usual.
  2. Import variables changes list unchanged token.

To Reproduce
Steps to reproduce the behavior:

  1. After adjusting the names of collections and modes, we changed the value of variable color, and try import:
    img_v3_02ej_e73aad6c-47b8-41f8-b95e-45043fa9aa4g
    As mentioned in Bug 1, the value of the changed token is updated, but the "updating generic remote" toast didn't show, and no update request is sent to the remote end.
    If we click "Apply to selection" or add/remove/edit token, it would update as usual.

Expect: "Import variables" should triggle updating.

  1. Import variables again, we saw changed list contained unchanged tokens:
    img_v3_02ej_f7053eec-a6ad-4dca-9e5e-c9a0145bb85g

As mentioned in Bug 2, unchanged token value should be hidden.

Expect: List changed token only.

Tasks

No tasks being tracked yet.
@kibbon
Copy link
Author

kibbon commented Sep 26, 2024

Remind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📥 Triage
Development

No branches or pull requests

1 participant