Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set protocol for npm to https #409

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

MatanBobi
Copy link
Member

Following testing-library/react-testing-library#975

Why:

npm notice Beginning October 4, 2021, all connections to the npm registry - including for package installation - must use TLS 1.2 or higher. You are currently using plaintext http to connect.

Checklist:

  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #409 (bb8a3c1) into main (d24b6be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          615       615           
  Branches       223       223           
=========================================
  Hits           615       615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d24b6be...bb8a3c1. Read the comment docs.

@MatanBobi MatanBobi requested a review from gnapse October 11, 2021 06:20
@gnapse gnapse merged commit d085039 into testing-library:main Oct 11, 2021
@gnapse
Copy link
Member

gnapse commented Oct 11, 2021

@all-contributors please add @MatanBobi for platform

@allcontributors
Copy link
Contributor

@gnapse

I've put up a pull request to add @MatanBobi! 🎉

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

🎉 This PR is included in version 5.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants