Mini Refactoring of Feedback button test #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3b3b043
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://229051eb.ui-c3x.pages.dev |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Alex-Tideman
approved these changes
May 6, 2022
Alex-Tideman
pushed a commit
that referenced
this pull request
May 9, 2022
Alex-Tideman
added a commit
that referenced
this pull request
May 10, 2022
* Refactor event view stores * Rename and remove event view code * Refactor sort order * Rename to event-view.ts * Fix issues * Add event category store * Move Writable to type import * Get the stores in place * Get client-side event store installed * Fix type issues * Fix error when navigating back to the workflow list * Refactor event view stores * Rename and remove event view code * Refactor sort order * Rename to event-view.ts * Update events.ts * Fix escaping * Update workflow-input-and-results.spec.js * Update event-history-empty-states.spec.js * Refactor tests * More test fixes * Update fetchEvents to use settings as well for data encoder * Fix stack trace tests * Add wait for event-history-api * Customize Feedback URL from settings (#519) * Customize Feedback URL from settings * add feedback url tests * Persisted query parameter store (#507) * Create persisted-search-parameter.ts * Make persistence optional * Update persisted-search-parameter.ts * Update persisted-search-parameter.ts * Fix lint issues * Better matching for query error (#522) * Better matching for query error * Remove console.logs * Add tests for workers page (#518) * Mini Refactoring of Feedback button test (#525) * Disable version banner based on configuration (#524) * Add cypress test for parsing Java query types (#523) * Deduplicate initial fetches on workflow list (#511) * Deduplicate initial fetches on workflow page * Make the UX more natural * Update workflows.ts * Add tests for Temporal Version banner (#526) * Remove data-encoder status on login page, add login page test (#527) * Remove data-encoder status on login page, add login page test * Add assertion that status does not exist on login page * Test /login redirect * WIP: add updating/loading to event store to follow * WIP: try with context * Update isNewRequest for events, refactor isLoading to util * Fix query test, set previous parameters as stores to clear out onDestroy Co-authored-by: Steve Kinney <hello@stevekinney.net> Co-authored-by: Ruslan <11838981+feedmeapples@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed separate fixture for Feedback URL settings, preferring to overwrite the URL param in
settings.jsonWhy?
Having too many fixture may complicate supporting them (esp with API changes). Preferred to change the settings in place where needed
Checklist
Closes
How was this tested: