Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Modal component with open and error props #1557

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Update Modal component with open and error props #1557

merged 3 commits into from
Aug 17, 2023

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Pass open and error props to the Modal Holocene component instead of having to add optional chaining if we call setError or close after an async function.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

  • Cancel should close the modal and clear an errors
  • Confirm should clear any errors and either close the modal (success) or display an error (failure)
  • Any inputs on the modal should be cleared on close
  • Verify the BatchOperationConfirmationModal works as expected
  • Verify the various WorkflowActions modals work as expected
  • Verify the Schedule pause and delete modals work as expected

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-1056

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from rossedfort and a team as code owners August 16, 2023 22:47
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview Aug 16, 2023 10:47pm

@laurakwhit laurakwhit merged commit 63a6b54 into main Aug 17, 2023
11 checks passed
@laurakwhit laurakwhit deleted the DT-1056-handle-async-functions-in-Holocene-modal branch August 17, 2023 22:04
Alex-Tideman pushed a commit that referenced this pull request Aug 23, 2023
@laurakwhit @Alex-Tideman
Update Modal component with open and error props (#1557)
daee43a 
* Update Modal to accept open and error props

* Update Modal instances

* Use bind to handle open and error on cancel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurakwhit @rossedfort