batch of a11y updates #1527
Merged
batch of a11y updates #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add icon titles to copy buttons and copy button in tooltips use 2000 ms default timeout for copyable - it gives SR time to announce new icon * add label to all icon buttons * clean up data-encoder-status and add labels * fix input label margin chip input support string or fn label add a common i18n string for cloud * move copyable to holocene * Update src/lib/components/event/event-details-row-expanded.svelte Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io> * rm namespace-selector * fix orderable-list-item types --------- Co-authored-by: Laura Whitaker <laura.whitaker@temporal.io>
* Add aria-label to all Tables * Add aria-label to Tables and translate Namespace details page * Fix font-style * Remove h6 from WorkflowStatus * Add aria-label to encoder button * Translate aria-labels, etc * Use caption instead of aria-label for Table components * Add sr-only version text to primary nav * Move main nav outside of main and ensure proper roles * Remove heading element from subtitle on Accordion * Only read version if there is one * Update table snapshot with span instead of h6 for Status
* make ToggleButton accessible add keyboard navigation and hover/focus state add screen reader support * fix disabled state * use min-w-fit on toggle switch for smaller screens * cleanup css * add hover state to checked toggle switch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Add aria-hidden to heartbeat svg on WorkflowStatus * Translate alt for user profile img * Add aria-labelledby to loading img * Remove link and alt from logo * Add title to icon and keyboard shortcut svgs * Update snapshots * Use for holocene links * CR feedback
* add an aria label to dropdown menu button * add label for split button menus
rossedfort
requested review from
Alex-Tideman and
laurakwhit
and removed request for
feedmeapples
laurakwhit
reviewed
Aug 10, 2023
| @@ -30,17 +30,19 @@ | |||
| } | |||
| </script> | |||
|
|
|||
| <div | |||
| <nav | |||
There was a problem hiding this comment.
Looks like clicking on data encoder settings no longer shows the settings unless you are at the top of the page
data encoder settings
laurakwhit
approved these changes
Aug 10, 2023
Alex-Tideman
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This is a PR for a large batch of a11y improvements to the UI
#1513 - Icon Button Labels
#1515 - Semantic HTML and Aria Updates
#1520 - Toggle Button a11y
#1535 - Namespace Switcher and Split Button a11y
#1537 - Alt text for Images
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?