You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to fully internationalize the UI, we need to make sure there are no hard-coded strings in Holocene components. This PR takes care of that with a few exceptions.
Day of Week Picker - this is hardcoded to use English days of the week for now
Month Picker - similarly this is hard coded to use English months for now
Error/Error Boundary - the library we are using to create the Error boundary does seem to let us pass props to the child components. For now the error text is hard coded in English.
I also moved some components out of src/lib/holocene and into src/lib/components, because they dealt with specific Temporal logic. Those include:
codec-endpoint-settings.svelte
data-converter-port-settings.svelte
data-encoder-settings.svelte
data-encoder-status.svelte
namespace-selector.svelte
These components can be translated at a later date.
I guess my general question is why pass in a prop with the translated text instead of translating the string directly in the Holocene component?
Good question. If we want to publicize Holocene as a UI component library that can be consumed by external users, they may already be using their own internationalization framework other than i18next, or they may not have any i18n requirement at all. If we translated strings directly in our Holocene components, we'd be requiring everyone who uses Holocene to also bundle i18next in their app and host their own json files with the strings in them. Having all the text as props makes the Holocene agnostic to any potential internationalization frameworks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rossedfort
requested review from
Alex-Tideman and
laurakwhit
and removed request for
GiantRobots
Description & motivation 💭
In order to fully internationalize the UI, we need to make sure there are no hard-coded strings in Holocene components. This PR takes care of that with a few exceptions.
I also moved some components out of
src/lib/holoceneand intosrc/lib/components, because they dealt with specific Temporal logic. Those include:These components can be translated at a later date.
Screenshots (if applicable) 📸
Design Considerations 🎨
N/a
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?