Include Import Page in Navigation #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Alex-Tideman
changed the title
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
…espace, allow sort on events, update tests
rossedfort
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Import Page in Navigation
Add nav icon to surface new icon for import page. Allow users to navigate to import page and upload event history. Once uploaded, show the Feed/Compact/JSON views of the event history. Disable 'Import' button if no file is selected.
Also included in this PR is increasing the global timeout of Playwright to 10 seconds to allow server to start. 3 new Playwright tests are included for the import page.
[x] Does this change require a design review?
No, Candace and I confirmed we want to keep the current design.
[x] Does this change require manual testing?
Yes. A new page on nav, with file uploading functionality. Shares code with EventSummary.