Expose CSRF cookie insecure setting as Docker env #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
feedmeapples
force-pushed
the
expose-cookie-insecure
branch
from
1d7eb42
to
5f1e7c1
Compare
robholland
requested changes
Feb 24, 2023
server/docker/config_template.yaml
Outdated
| @@ -16,6 +16,7 @@ workflowSignalDisabled: {{ default .Env.TEMPORAL_WORKFLOW_SIGNAL_DISABLED "false | |||
| workflowResetDisabled: {{ default .Env.TEMPORAL_WORKFLOW_RESET_DISABLED "false" }} | |||
| batchActionsDisabled: {{ default .Env.TEMPORAL_BATCH_ACTIONS_DISABLED "false" }} | |||
| cors: | |||
| cookieInsecure: {{ default .Env.TEMPORAL_COOKIE_INSECURE "false" }} | |||
There was a problem hiding this comment.
I think better to include either CORS or CSRF in the env var name.
feedmeapples
changed the title
robholland
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Exposed
cookieInsecureas Docker env variableWhy?
Users who secure their UI deployments in non-HTTPS manner may want to disable secure cookie so CSRF cookie is sent over HTTP
Checklist
Closes
How was this tested:
Changed the value in development.yaml and verified it is being set