Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python release #1957

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Python release #1957

merged 3 commits into from
Jun 7, 2023

Conversation

roggervalf
Copy link
Collaborator

No description provided.

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but don't we also need a build step for the lua scripts?

redis==4.5.5
semver==3.0.0
semver==2.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an older version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a conflict with python semantic release that is using version 2, as we are using the same method for both version is working for us as well

@roggervalf
Copy link
Collaborator Author

Looks good, but don't we also need a build step for the lua scripts?

in line 36 we are copying lua scripts

@roggervalf roggervalf merged commit 83cd060 into master Jun 7, 2023
@roggervalf roggervalf deleted the python-release branch June 7, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants