fix(rate-limit): consider paused queue #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
commented
Jun 1, 2023
| local pttl = rcall("PTTL", rateLimiterKey) | ||
|
|
||
| if pttl <= 0 then | ||
| rcall("DEL", rateLimiterKey) |
There was a problem hiding this comment.
we can delete the key here if it's 0
| -- remove from active queue and add back to the wait list | ||
| rcall("LREM", keys[2], 1, jobId) | ||
| rcall("RPUSH", keys[1], jobId) | ||
| rcall("RPUSH", targetKey, jobId) |
There was a problem hiding this comment.
consider paused queue, not only wait list
| @@ -67,6 +67,11 @@ end | |||
| if jobId then | |||
| if string.sub(jobId, 1, 2) == "0:" then | |||
| rcall("LREM", KEYS[2], 1, jobId) | |||
|
|
|||
| if expireTime > 0 then | |||
| return { 0, 0, expireTime, 0 } | |||
There was a problem hiding this comment.
as we delete the previous marker, if expireTime is greater than 0 (in rate-limit), we can return expireTime
roggervalf
commented
Jun 5, 2023
| }); | ||
| }); | ||
|
|
||
| await delay(500); |
There was a problem hiding this comment.
in order to get drained attribute as true for all workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.