Making the parser stateless

symfony · Jan 24, 2022 · d7f637c · d7f637c
1 parent d7827c7
commit d7f637c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/Parser.php b/Parser.php
@@ -98,6 +98,8 @@ public function parse(string $value, int $flags = 0)
             if (null !== $mbEncoding) {
                 mb_internal_encoding($mbEncoding);
             }
+            $this->refsBeingParsed = [];
+            $this->offset = 0;
             $this->lines = [];
             $this->currentLine = '';
             $this->refs = [];

diff --git a/Tests/ParserTest.php b/Tests/ParserTest.php
@@ -84,6 +84,20 @@ public function invalidIndentation(): array
         ];
     }
 
+    public function testParserIsStateless()
+    {
+        $yamlString = '# translations/messages.en.yaml
+
+';
+        $this->parser->parse($yamlString);
+        $this->parser->parse($yamlString);
+
+        $this->expectException(ParseException::class);
+        $this->expectExceptionMessage("A YAML file cannot contain tabs as indentation at line 2 (near \"\tabc\")");
+
+        $this->parser->parse("abc:\n\tabc");
+    }
+
     /**
      * @dataProvider validTokenSeparators
      */