Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for adding secets to deployment #3

Merged
merged 12 commits into from
Sep 13, 2022
Merged

adding support for adding secets to deployment #3

merged 12 commits into from
Sep 13, 2022

Conversation

nicksrandall
Copy link
Contributor

Fixes #2

mattrigg9
mattrigg9 approved these changes Jun 15, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@mattrigg9
Copy link
Contributor

Tested and verified working as expected on my own environment. Thank you!

@nicksrandall @mattrigg9
Update action.yml
b2043f5 
Co-authored-by: Matt <matt@mattrigg.dev>
@Jrubensson
Copy link

Jrubensson commented Jun 17, 2022 •
edited
Loading

It seems like the latest change to the action.yml broke the functionality. I am getting this error:

Error: nicksrandall/fly-pr-review-apps/main/action.yml (Line: 27, Col: 18):
Error: nicksrandall/fly-pr-review-apps/main/action.yml (Line: 27, Col: 18): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.FIRST_SECRET
Error: Fail to load nicksrandall/fly-pr-review-apps/main/action.yml

@nervetattoo
Copy link

I've fixed the errors and added support for things like updating secrets on updates in my fork. Might do another PR with it eventually but feel free to use it until then.

https://github.com/nervetattoo/fly-pr-review-apps

allezxandre
allezxandre reviewed Sep 4, 2022
View reviewed changes
entrypoint.sh
flyctl launch --now --copy-config --name "$app" --image "$image" --region "$region" --org "$org"
flyctl launch --no-deploy --copy-config --name "$app" --image "$image" --region "$region" --org "$org"
if [ -n "$INPUT_SECRETS" ]; then
echo $INPUT_SECRETS | tr " " "\n" | flyctl secrets import --app "$app"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this break with secrets that contain spaces?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, but I think that's ok for now. I'm going to go ahead and merge this and we can make the new option more resilient on a second pass.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkurt My secret has spaces and the action doesn't work

GOOGLE_PRIVATE_KEY=-----BEGIN PRIVATE KEY-----\nxxx\n-----END PRIVATE KEY-----\n

Is there any walkaround?

@mrkurt mrkurt merged commit 5d5f1c2 into superfly:main Sep 13, 2022
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
99d4a4e
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
f45302b
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
be5d364
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
0c0848d
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
f48c0f6
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
c61d584
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
bff1036
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
f305061
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
5f78dd7
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
f576e2c
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
255c933
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 16, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
a4fdded
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 17, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
39613dc
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 17, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
898f03d
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
fc706c3
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
151ccc0
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
56574c1
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
abb850f
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
9c6b1fb
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
7b8df48
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
2954e00
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
b64c43f
steph-crown referenced this pull request in steph-crown/fly-pr-review-apps Jan 18, 2023
@nicksrandall @steph-crown
support for adding secrets to deployment (Projectstake#3)
0967975
amos-kibet referenced this pull request in amos-kibet/fly-preview-apps Apr 17, 2023
@jeromegn
Merge pull request optimumBA#3 from stefanluptak/patch-1
4f7d58c 
Fix flyctl link in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkurt mrkurt mrkurt left review comments

@allezxandre allezxandre allezxandre left review comments

@HuyAms HuyAms HuyAms left review comments

@mattrigg9 mattrigg9 mattrigg9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage with secrets
7 participants
@nicksrandall @mattrigg9 @Jrubensson @nervetattoo @mrkurt @allezxandre @HuyAms