Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialisation of fields with SW stagger not consistent with NE stagger #46

Open
arporter opened this issue Jul 20, 2020 · 0 comments
Open
Labels

Comments

@arporter
Copy link
Member

At some point in the past I simplified all of the loop bounds by requiring all field types to have the same dimensions and capturing their differences in the mask information. However, it seems that I was slack and only actually changed the implementation for the initialisation routines for NE stagger (that used by NemoLite2d). Those for SW stagger still do +/-1 and that's an important oversight because they're used in Shallow which @sergisiso has been trying to get working recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant