From d63f190b18df030f0a2879dee8c00717e2911920 Mon Sep 17 00:00:00 2001 From: Duncan McClean Date: Mon, 22 Jan 2024 14:10:23 +0000 Subject: [PATCH] Bard: Only configure placeholder extension when placeholder is provided --- .../js/components/fieldtypes/bard/BardFieldtype.vue | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/resources/js/components/fieldtypes/bard/BardFieldtype.vue b/resources/js/components/fieldtypes/bard/BardFieldtype.vue index d558ef9855..b671102bad 100644 --- a/resources/js/components/fieldtypes/bard/BardFieldtype.vue +++ b/resources/js/components/fieldtypes/bard/BardFieldtype.vue @@ -706,6 +706,7 @@ export default { getExtensions() { let modeExts = this.inputIsInline ? [DocumentInline] : [DocumentBlock, HardBreak]; + if (this.config.inline === 'break') { modeExts.push(HardBreak.extend({ addKeyboardShortcuts() { @@ -716,8 +717,12 @@ export default { }, })); } - - // Allow passthrough of Ctrl/Cmd + Enter to submit the form + + if (this.config.placeholder) { + modeExts.push(Placeholder.configure({ placeholder: __(this.config.placeholder) })); + } + + // Allow passthrough of Ctrl/Cmd + Enter to submit the form const DisableCtrlEnter = Extension.create({ addKeyboardShortcuts() { return { @@ -735,7 +740,6 @@ export default { Gapcursor, History, Paragraph, - Placeholder.configure({ placeholder: __(this.config.placeholder) }), Set.configure({ bard: this }), Text ];