-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.50.0 changes naming of nested GraphQL fragments #9633
Comments
Can you provide the YAML file contents for the relevant blueprint? |
Sure, here it is page_builder.yaml title: 'Page Builder'
fields:
-
handle: page_builder
field:
sets:
main:
sets:
text:
fields:
-
import: page_builder_text page_builder_text.yaml title: 'Page Builder Text'
fields:
-
handle: text_rich
field: common.text_rich
common.yaml title: Common
fields:
- handle: text_rich
field:
sets:
main:
sets:
buttons:
display: Buttons
instructions: null
icon: direction-buttons
fields:
- import: buttons
type: bard buttons.yaml title: Buttons
fields:
- handle: buttons
field:
fields:
- import: button
type: grid |
Same behaviour here since the update to v4.51 We have two replicators with the handles:
Each replicator contains a set of fieldtypes which we define in the frontend as reusable query string for graphql.
So e.g. to fetch the replicator on the page:
Since the update it is necessary to prefix the Set_Links_Link with the parent replicator handle:
|
Would you be able to confirm the exact version where this behavior starts changing? |
We updated from v4.46 to v4.51 |
Yes, can confirm that. It starts with 4.50 |
Thank you |
Yes this is currently preventing us from updating Statamic, as it breaks all defined graphQL fragments in the application. |
We are also blocked from upgrading Statamic for the same reason. We've locked the version to 4.49 for now. |
What is the status of this issue? The ticket has been open since March. Does this mean that the GraphQL nested fields schema has changed permanently? |
I understand this has unintentionally changed at some point which shouldn't have in a non-breaking release. However, I don't see why it's stopping you from updating. Statamic 5 is a major release with breaking changes. Can't you also change your queries to use the updated names as part of the update? -fragment SetButtons on Set_TextRich_Buttons {
+fragment SetButtons on Set_PageBuilder_TextRich_Buttons { These new names seem more correct as they are scoped to the field. |
Bug description
Fragments names for nested fields have changed. I will try to add more detail later.
Before:
After:
How to reproduce
Upgrade to 4.50.0
Logs
No response
Environment
Installation
Fresh statamic/statamic site via CLI
Antlers Parser
Runtime (default)
Additional details
No response
The text was updated successfully, but these errors were encountered: