Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Integration: Wrong Commit Message #2921

Open
aerni opened this issue Nov 26, 2020 · 3 comments
Open

Git Integration: Wrong Commit Message #2921

aerni opened this issue Nov 26, 2020 · 3 comments
Labels

Comments

@aerni
Copy link
Contributor

aerni commented Nov 26, 2020

Bug Description

Super nitpicking but here you go … When saving an entry from a collection named pages, the commit message reads Collection saved rather than Entry saved like with all other collections.

How to Reproduce

  • Enable the Git Integration
  • Save an entry from a pages collection
  • Save an entry from another collection
  • Compare the commit messages

Environment

Statamic 3.0.30 Pro
Laravel 8.16.0
PHP 7.4.12
aerni/social-links 2.1.0
aerni/zipper 1.2.0
jonassiewertsen/statamic-livewire 2.1.2
spatie/statamic-responsive-images 1.4.0
visuellverstehen/statamic-classify 2.0.0

@duncanmcclean
Copy link
Member

duncanmcclean commented Nov 26, 2020

I can confirm this issue, it's happening on some of my sites too. See doublethreedigital/sc-docs.doublethree.digital #503fd4d

I imagine this is quite an easy one to fix. Should be in resources/lang/en somewhere.

@jesseleite
Copy link
Member

@damcclean Not related to a language file. I think this is due to how multiple changes are saved at once (entry, as well as collection's tree), then git add {{ paths }} is run, adding both paths at once and committing with the CollectionSaved event's message first. Think I have an idea how to fix this though.

@jesseleite jesseleite self-assigned this Nov 27, 2020
@github-actions github-actions bot added the stale label Jan 26, 2021
@aerni
Copy link
Contributor Author

aerni commented Jan 26, 2021

Still an issue.

@github-actions github-actions bot removed the stale label Jan 27, 2021
@jasonvarga jasonvarga removed the bug label Sep 22, 2023
@statamic statamic deleted a comment from github-actions bot Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants