-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cascade method getViewData should only return the data from the current view and not all of it. #10703
Comments
I ignored both above.. If you are interested about what i wanted to do, this is how I got the view param: class Attributes extends Tags
{
/**
* A bit hacky...
*/
private function getViewName()
{
$reflectionProperty = new \ReflectionProperty(RuntimeParser::class, 'view');
$reflectionProperty->setAccessible(true);
return $reflectionProperty->getValue($this->parser);
}
private function getParamsFromCascade()
{
return Arr::get(
Cascade::instance()->get('views', []),
$this->getViewName(),
[]
);
}
/* [...] */
} |
Just to clarify, you're saying that variables from previous "replicator sets" are leaking into the cascade? Are you able to ptovide an example? |
Thanks - I see it now. By the way. you don't need to build a custom tag for debugging, you can just do |
Bug description
I am currently creating a tag which takes all the param from the view and merge them to act like the AttributesBag from blade.
For this, i was using $this->context->view as a reference to the param of the current view. But i soon realized that if i didn't put the param
class
in each of my block using this tag, i would get a leak from a block that used theclass
param.Example:
{{ partial:layout/block_1 class="cool_class" }} {{ partial:layout/block_2}} // if I check $this->contect->view here, it will have the class=>cool_class param
So i went out of my way by using the "view" property from the RuntimeParser to execute the Cascade::instance()->getViewData() method.
It works, but i get the same result.
I checked the method and i feel something is wrong with it. It gets the data from all views each time, and overwrite (merge) the current's view data, which feel unituitive because it's not only the view data, it's ALL the data.
I look through the code and it's not used a lot so maybe it's an oversight.
For the time being, i'll use Cascade::instance()->get('views) and get the array i need.
ButI felt it needed to be revised.
How to reproduce
Logs
No response
Environment
Installation
Fresh statamic/statamic site via CLI
Additional details
No response
The text was updated successfully, but these errors were encountered: