Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added keep order to bash, zsh, pwsh & fish #1903

Merged
merged 10 commits into from
Feb 25, 2023
Merged

added keep order to bash, zsh, pwsh & fish #1903

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3adbf8
added keep order to bash, zsh, powershell & fish
h4ck3rk3y Jan 30, 2023
bc561bc
fix a tiny bug with bash
h4ck3rk3y Jan 30, 2023
6e475b6
fix indentation
h4ck3rk3y Jan 30, 2023
87cd943
added keep order to default bash completions
h4ck3rk3y Jan 30, 2023
3fc2de1
removed changes that arent necessary for new bash
h4ck3rk3y Feb 2, 2023
22ae670
fix fish
h4ck3rk3y Feb 7, 2023
cbcd050
worked on some reviews
h4ck3rk3y Feb 13, 2023
d115eb6
support bash3
h4ck3rk3y Feb 13, 2023
fcd84a9
added a comment
h4ck3rk3y Feb 13, 2023
3b1d173
added logic to reduce calls to underlying program
h4ck3rk3y Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added a comment
  • Loading branch information
@h4ck3rk3y
h4ck3rk3y committed Feb 13, 2023
commit fcd84a98d16af70fcd249c27f99ae8690adab443
9 changes: 7 additions & 2 deletions bash_completionsV2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,13 @@ __%[1]s_process_completion_results() {
fi
if (((directive & shellCompDirectiveKeepOrder) != 0)); then
if [[ $(type -t compopt) == builtin ]]; then
__%[1]s_debug "Activating keep order"
compopt -o nosort
# no sort isn't supported for bash less than < 4.4
if [[ ${BASH_VERSINFO[0]} -lt 4 || ( ${BASH_VERSINFO[0]} -eq 4 && ${BASH_VERSINFO[1]} -lt 4 ) ]]; then
__%[1]s_debug "No sort directive not supported in this version of bash"
else
__%[1]s_debug "Activating keep order"
compopt -o nosort
fi
else
__%[1]s_debug "No sort directive not supported in this version of bash"
fi
Expand Down