Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connexion 2.0 #619

Merged
merged 95 commits into from
Nov 5, 2018
Merged

Connexion 2.0 #619

merged 95 commits into from
Nov 5, 2018

Conversation

jmcs
Copy link
Contributor

@jmcs jmcs commented Jul 10, 2018

Changes:

  • Removed vendored swagger ui and added swagger-ui-bundle as an optional dependency.

…ra (#618)

* use external swagger_ui_bundle package, remove vendored files
* add swagger-ui-bundle to test requirements
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.553% when pulling eb374a6 on dev-2.0 into 0c352cd on master.

@coveralls
Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage decreased (-0.2%) to 99.79% when pulling 32a9ca5 on dev-2.0 into b6bb9dd on master.

@dtkav
Copy link
Collaborator

dtkav commented Jul 12, 2018

Hey @jmcs, do you know if merging from a staging branch like this will squash the commits, and remove the contributor information? If it would be possible to keep big changes as separate commits and contributor info preserved, that would be nice (whenever you are ready to merge).
I'm not sure if that would mean cherry-picking vs. merging or what, but it would mean a lot to me.

@jmcs
Copy link
Contributor Author

jmcs commented Jul 12, 2018

@dtkav both rebase and squash show the changes as commited by me but authored by you:
image

If you prefer I can create a merge commit instead.

@dtkav
Copy link
Collaborator

dtkav commented Jul 12, 2018

Oh cool, I thought github would just squash everything into a single huge commit and put the committer as the author. I haven't used this flow before - thanks for clarifying!

@spec-first spec-first deleted a comment Jul 13, 2018
@spec-first spec-first deleted a comment Jul 13, 2018
@spec-first spec-first deleted a comment Oct 5, 2018
@hjacobs hjacobs added this to the 2.0 milestone Oct 18, 2018
@spec-first spec-first deleted a comment Oct 20, 2018
@jmcs
Copy link
Contributor Author

jmcs commented Oct 26, 2018

@dtkav
Copy link
Collaborator

dtkav commented Oct 27, 2018

AFAICT #732 is backwards compatible. Couldn't it be in the 2.1 release?
#735 should address #729

@spec-first spec-first deleted a comment Oct 27, 2018
@jmcs
Copy link
Contributor Author

jmcs commented Oct 29, 2018

I released 2.0.0rc4.

* Add App(resolver=...) for app-wide default resolver

* test api.resolver _is_ resolver
@jmcs
Copy link
Contributor Author

jmcs commented Oct 29, 2018

I released 2.0.0rc5 because I had forgotten #735 🤦‍♂️.

@spec-first spec-first deleted a comment Oct 29, 2018
@dtkav
Copy link
Collaborator

dtkav commented Oct 29, 2018

IMHO we should call it and do the release now. JWT support is backwards compatible, so it could be in 2.1.
I'm trying to practice patience, but at the same time this release cycle has been very long.
What do you think?

 - update docs to pass swagger_ui in options instead of kwargs
@spec-first spec-first deleted a comment Nov 1, 2018
@jmcs jmcs changed the title WIP Connexion 2.0 Connexion 2.0 Nov 5, 2018
@jmcs jmcs requested a review from dtkav November 5, 2018 13:42
@jmcs
Copy link
Contributor Author

jmcs commented Nov 5, 2018

👍

1 similar comment
@marcinzaremba
Copy link

👍

@jmcs jmcs merged commit 44ea933 into master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants