Validate parameter list #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,8 +167,9 @@ def validate_schema(self, data): | |||
|
|
|||
|
|
|||
| class ParameterValidator(object): | |||
| def __init__(self, parameters): | |||
| def __init__(self, parameters, strict_validation=False): | |||
There was a problem hiding this comment.
Can you add a docstring explaining what strict_validation does?
|
Thanks for the Pull Request. The code looks ok but can you also update the documentation? |
|
Hi @dsem -- checking in here. Did you update the documentation? |
|
Sorry, I will mike time for this this weekend. Thanks for reaching out. |
dsem
force-pushed
the
validate-parameter-list
branch
from
1eeae1b
to
6c113c5
Compare
Request validation is enhanced to verify requests only include query or formData parameters that are specified in the spec. This validation does not occur for header or path parameters. This is because most applications probably prefer to ignore extra headers and a request with extra path parameters would point to a different endpoint.
dsem
force-pushed
the
validate-parameter-list
branch
from
6c113c5
to
fd69a37
Compare
|
Thanks, all. I've updated the documentation and resolved merge conflicts. |
|
👍 |
|
Thanks for the Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223 .
Changes proposed in this pull request:
add_api()andApito enable this validation.