Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1424: add keywords to the list of pythonic words #1425

Merged
merged 7 commits into from
Sep 13, 2021
Merged

#1424: add keywords to the list of pythonic words #1425

merged 7 commits into from
Sep 13, 2021

Conversation

daisieh
Copy link
Contributor

@daisieh daisieh commented Sep 10, 2021

Fixes #1424 .

Changes proposed in this pull request:

  • Add Python's keywords to the list of reserved words for underscoring.

@coveralls
Copy link

coveralls commented Sep 10, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.036% when pulling 594ecbc on daisieh:patch-1 into 2dfd57d on zalando:main.

Ruwann
Ruwann reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR (and the updated tests)! Looks great!
I left one comment to avoid building a list

connexion/decorators/parameter.py Outdated Show resolved Hide resolved
@daisieh @Ruwann
Update connexion/decorators/parameter.py
594ecbc 
Co-authored-by: Ruwann <ruwan.lambrichts@ml6.eu>
Ruwann
Ruwann approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ruwann Ruwann merged commit 4fd5d63 into spec-first:main Sep 13, 2021
@daisieh daisieh deleted the patch-1 branch September 13, 2021 20:10
@daisieh daisieh mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameters named "class" (or other python reserved words) don't work, even with pythonic_params=True?
3 participants
@daisieh @coveralls @Ruwann