Don't import concrete security factories in init #1377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concrete
SecurityHandlerFactory
implementations require the corresponding libraries to be installed.When importing them in
security.__init__.py
, this can raise an ImportError.For example, when running the helloworld example which uses
FlaskApp
and shouldn't requireaiohttp
:This PR addresses this by not importing the concrete classes in
security.__init__.py
. Another option is to do something similar toconnexion.__init__.py
, but I opted for this approach because theSecurityHandlerFactory
isn't exposed directly to the end user, but happy to change it so this also uses that approach.