Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8: replace @asyncio.coroutine/yield from with async/await #1182 #1186

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

szborows
Copy link
Contributor

Fixes #1182 .

Changes proposed in this pull request:

  • replaced @asyncio.coroutine and yield from with async and await respectively

@coveralls
Copy link

coveralls commented Mar 21, 2020

Coverage Status

Coverage decreased (-0.005%) to 96.291% when pulling 79219bf on szborows:master into 7e08135 on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Apr 4, 2020

👍

1 similar comment
@hjacobs
Copy link
Contributor

hjacobs commented Apr 23, 2020

👍

@szborows
Copy link
Contributor Author

szborows commented Apr 24, 2020

@hjacobs I think you need to use await instead of yield from

Edit: after years of using GitLab I'm not used to GitHub. Apparently you just merged something in. I rebased my fork to upstream's master and going to make it green again.

…3.8)

Signed-off-by: Sławomir Zborowski <slawomir.zborowski@nokia.com>
@szborows
Copy link
Contributor Author

@hjacobs it's green except coverage. Please advise: what to do with this -0.005%?

@hjacobs
Copy link
Contributor

hjacobs commented Apr 25, 2020

👍

@hjacobs hjacobs merged commit bed4b95 into spec-first:master Apr 25, 2020
vmarkovtsev added a commit to vmarkovtsev/connexion that referenced this pull request May 7, 2020
…ecorators

This is the place missed in spec-first#1186 that gives annoying `DeprecationWarning`-s in `pytest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 asyncio.coroutine deprecated
3 participants