Fixes #510: Multiple file uploads via POST now work correctly. #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work correctly.
|
Thanks! |
|
👍 |
|
I believe this change breaks the aiohttp api. aiohttp passes a dict and not a wz.datatypes.ImmutableMultiDict as flask does. So there is no getlist() method to call. |
|
Hey @ddurham2 good catch. We have a lot of problems with aiohttp / flask compatibility since the API is not well defined and tests aren't shared between the two frameworks. |
dtkav
added a commit
that referenced
this pull request
Dec 13, 2019
hjacobs
pushed a commit
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fix issue #510