Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): expose additional needed types #1394

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(typings): expose additional needed types #1394

merged 1 commit into from
Nov 9, 2020

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Nov 8, 2020

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Needed types are not exposed by package index. These were exposed by @types/socket.io-client

New behaviour

Package index re-exports additional types.

Other information (e.g. related issues)

Caught while upgrading to the new major.

these were exposed by @types/socket.io-client
@darrachequesne darrachequesne merged commit 19ab1e9 into socketio:master Nov 9, 2020
@darrachequesne darrachequesne added this to the 3.0.1 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants