Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent type with asserts #13

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

thonic
Copy link

@thonic thonic commented Nov 6, 2017

if you want to use the convert_continuous_to_discrete function with the rest of the models, such as:
pyhawkes.models.DiscreteTimeNetworkHawkesModelSpikeAndSlab.add_data()
it will now scream

"Data must be a TxK array of event counts"

because of assert S.dtype == np.int

this changes the returned type so that it is consistent with the rest of the code

@slinderman slinderman merged commit 49ed340 into slinderman:master Nov 13, 2017
@slinderman
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants