Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): always log loader error at server side #557

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Repraance
Copy link
Contributor

What kind of change does this PR introduce?

Did you add tests(unit,e2e) for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

if (process.env.NODE_ENV === 'development') {
logger.error(error.stack);
}
logger.error(error.stack);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

貌似只改这里就可以了,不需要改动loader.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@liximomo liximomo merged commit a1e297b into shuvijs:main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants