-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: accept any order of params #45
Conversation
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
a194f0a
to
cbbf6aa
Compare
@jimmy-guzman about Typescript component logic of required/not required, tell me if this is enough. export type CustomThemeProvider = React.ComponentType<{ theme: Theme, children: React.ReactNode }> |
@semoal yeah that's enough. Thanks. |
@@ -0,0 +1,17 @@ | |||
export function isClassComponent(component: any): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export function isClassComponent(component: any): boolean { | |
// eslint-disable-next-line @typescript-eslint/no-explicit-any | |
export function isClassComponent(component: any): boolean { |
Just a thought.
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DEFAULT_SETTINGS
DEFAULT_SETTINGS
if they are not equals to default, this is helpful to pass inside settingsCustomThemeProvider
and keep the logic ofdisableThemePreview
CustomThemeProvider
I think it's all 👍🏻